Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1469] init pr for short term python version issue fix #307

Merged
merged 6 commits into from
Nov 10, 2022
Merged

[CT-1469] init pr for short term python version issue fix #307

merged 6 commits into from
Nov 10, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Nov 3, 2022 •
edited by dbeatty10
Loading

resolves dbt-labs/dbt-core#6203

Description

Upgrade actions/setup-python from v2 to v4.3.0 to bring in all the updates for deprecations
Defines Python Version to use when installing dependencies

Checklist

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Nov 3, 2022
@McKnight-42 McKnight-42 self-assigned this Nov 3, 2022
@cla-bot cla-bot bot added the cla:yes label Nov 3, 2022
@McKnight-42 McKnight-42 closed this Nov 3, 2022
@McKnight-42 McKnight-42 reopened this Nov 3, 2022
leahwicz
leahwicz reviewed Nov 3, 2022
View reviewed changes
dbt/adapters/snowflake/connections.py Outdated
@@ -34,7 +34,7 @@
RuntimeException,
FailedToConnectException,
DatabaseException,
warn_or_error,
warn_or_error, # type: ignore[attr-defined]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something new needed?

Copy link
Contributor Author

@McKnight-42 McKnight-42 Nov 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this will be removed, looking into the failure cause

@McKnight-42 McKnight-42 requested a review from leahwicz November 4, 2022 16:13
@emmyoop emmyoop mentioned this pull request Nov 4, 2022
Merged
6 tasks
@McKnight-42
Copy link
Contributor Author

@leahwicz this should now be good for review to start the snowflake changes and backports

dbeatty10
dbeatty10 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

Found #307 when troubleshooting why a test for #280 was failing.

@dbeatty10
Copy link
Contributor

@McKnight-42 do we want these backport labels like in dbt-labs/dbt-redshift#211?
image

It doesn't look like dbt-labs/dbt-bigquery#378 or dbt-labs/dbt-spark#508 have the backport labels 🤷

@dbeatty10 dbeatty10 mentioned this pull request Nov 10, 2022
Merged
@McKnight-42
Copy link
Contributor Author

McKnight-42 commented Nov 10, 2022 •
edited
Loading

@dbeatty10 they will have to be backported but our gha isn't working on 1.2.latest and 1.1.latest last I checked so have to do those manually, currently have a few on the other prs as well

@dbeatty10
Copy link
Contributor

@McKnight-42 who will merge this PR? I am happy to do so if desired. I think our CI will continue to fail until this is merged, so I am waiting for this before merging #280.

Also: who will create the backports for 1.2.latest and 1.1.latest?

@McKnight-42
Copy link
Contributor Author

I will merge it today and throw up backports for @leah and @jtcohen6 to approve.

@McKnight-42 McKnight-42 merged commit 6fecea9 into main Nov 10, 2022
@McKnight-42 McKnight-42 deleted the mcknight/ct-1469 branch November 10, 2022 18:01
McKnight-42 added a commit that referenced this pull request Nov 10, 2022
@McKnight-42
[CT-1469] init pr for short term python version issue fix (#307)
42f04cc 
* [CT-1469] init pr for short term python version issue fix

* seeing if adding py311 as option in tox fixes

* removing ref to py311

* seeing if ignoring error helps

* remove useful mypy ignore
McKnight-42 added a commit that referenced this pull request Nov 10, 2022
@McKnight-42
[CT-1469] init pr for short term python version issue fix (#307)
17cc858 
* [CT-1469] init pr for short term python version issue fix

* seeing if adding py311 as option in tox fixes

* removing ref to py311

* seeing if ignoring error helps

* remove useful mypy ignore
McKnight-42 added a commit that referenced this pull request Nov 10, 2022
@McKnight-42
[CT-1469] init pr for short term python version issue fix (#307)
ac0a316 
* [CT-1469] init pr for short term python version issue fix

* seeing if adding py311 as option in tox fixes

* removing ref to py311

* seeing if ignoring error helps

* remove useful mypy ignore
McKnight-42 added a commit that referenced this pull request Nov 14, 2022
@McKnight-42
[CT-1469] init pr for short term python version issue fix (#307) (#319)
a1efcac 
* [CT-1469] init pr for short term python version issue fix

* seeing if adding py311 as option in tox fixes

* removing ref to py311

* seeing if ignoring error helps

* remove useful mypy ignore
McKnight-42 added a commit that referenced this pull request Nov 14, 2022
@McKnight-42
[CT-1469] init pr for short term python version issue fix (#307) (#318)
4173f09 
* [CT-1469] init pr for short term python version issue fix

* seeing if adding py311 as option in tox fixes

* removing ref to py311

* seeing if ignoring error helps

* remove useful mypy ignore
McKnight-42 added a commit that referenced this pull request Nov 14, 2022
@McKnight-42
[CT-1469] init pr for short term python version issue fix (#307) (#317)
c556484 
* [CT-1469] init pr for short term python version issue fix

* seeing if adding py311 as option in tox fixes

* removing ref to py311

* seeing if ignoring error helps

* remove useful mypy ignore
alexander-smolyakov pushed a commit to dbt-labs/dbt-snowflake-release-test that referenced this pull request Dec 13, 2022
@McKnight-42 @alexander-smolyakov
[CT-1469] init pr for short term python version issue fix (dbt-labs#307)
a4b1416 
* [CT-1469] init pr for short term python version issue fix

* seeing if adding py311 as option in tox fixes

* removing ref to py311

* seeing if ignoring error helps

* remove useful mypy ignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 approved these changes

@emmyoop emmyoop Awaiting requested review from emmyoop

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may

@leahwicz leahwicz Awaiting requested review from leahwicz

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1469] [Bug] Define Python Version when Installing Dependencies
3 participants
@McKnight-42 @dbeatty10 @leahwicz