Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add host/port/protocol as optional profile parameters #36

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

laxjesse
Copy link
Contributor

@laxjesse laxjesse commented Oct 26, 2021

resolves #21

Description

Adds optional profile parameters that are useful for atypical local connection setups

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-snowflake next" section.

@cla-bot cla-bot bot added the cla:yes label Oct 26, 2021
@laxjesse laxjesse force-pushed the add_option_credential_args branch from f96906c to 92b3a0f Compare October 26, 2021 14:27
@laxjesse
Copy link
Contributor Author

I don't think that an integration test is in scope for this since it would require some snowflake configuration as well as a proxy

Also apologies if I updated the changelog incorrectly I can fix if need be

@jtcohen6
Copy link
Contributor

@laxjesse Looks good to me. I agree that an automated integration test for this would be difficult.

Have you been able to test these changes locally, with your proxy setup, and confirm that they're working?

@laxjesse
Copy link
Contributor Author

Have you been able to test these changes locally, with your proxy setup, and confirm that they're working?

Yes, dbt debug works and I'm able to run an example model (e.g select 1) with our using multiple different combinations of the arguments added

I can't speak to whether or not this will work for all possible set ups but I think this exposes pretty much every argument you can tweak in the snowflake python connector to get a proxy to work without using the environment variables snowflake recommends

@laxjesse laxjesse force-pushed the add_option_credential_args branch from 92b3a0f to a699e47 Compare October 27, 2021 13:35
@laxjesse
Copy link
Contributor Author

force pushed to fix some trailing whitespace that was throwing a flake error

@laxjesse
Copy link
Contributor Author

looks like these test failures were fixed in #37 , rebasing to see if that helps

@laxjesse laxjesse force-pushed the add_option_credential_args branch from a699e47 to 5a3baae Compare October 27, 2021 20:29
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @laxjesse!

@jtcohen6 jtcohen6 merged commit ce157c0 into dbt-labs:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt snowflake connections through proxy no longer work
2 participants