Convert incremental on_schema_change tests #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
commented
Jan 14, 2023
jtcohen6
changed the title
jtcohen6
force-pushed
the
jerco/convert-onschemachange-tests
branch
from
f58ee56
to
8dbf6f3
Compare
5 tasks
ChenyuLInx
approved these changes
Jan 18, 2023
jtcohen6
force-pushed
the
jerco/convert-onschemachange-tests
branch
from
5a99a99
to
2a105af
Compare
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Jan 19, 2023
* Convert incremental on_schema_change tests * Switch to dbt-core main
colin-rogers-dbt
added a commit
that referenced
this pull request
Jan 19, 2023
* Mp/reduce ci daily run intervals (#392) * Only run at 7:00 am est (before folks get into the office) * Split jobs and adjust timestamps. * Trim comments. * Need both workflows on each job. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com> * [CT-1507] create config for incremental models to use temp tables or views to fix regression in perf (#389) * init push for pr to work on regression in temp tables vs views for dbt-snowflake * adding additional table selection logic, functionality works locally based off snowflake query history * extend condition logic to smaller more readable elif's take into account some lost table options * add changie * breaking out language selection for more readability, reorganizing conditional flow * typo fix * spacing fix * change messaging for incremental model strategy selection * add direct reference to delete+insert * changing comment formatting and structure * Convert incremental on_schema_change tests (#398) * Convert incremental on_schema_change tests * Switch to dbt-core main * [CT-1507] part 2: Expand configuration to all strategies (#403) * init push for pr to work on regression in temp tables vs views for dbt-snowflake * adding additional table selection logic, functionality works locally based off snowflake query history * extend condition logic to smaller more readable elif's take into account some lost table options * add changie * breaking out language selection for more readability, reorganizing conditional flow * typo fix * spacing fix * change messaging for incremental model strategy selection * add direct reference to delete+insert * changing comment formatting and structure * expand tmp_relation_type to be configurable for all incremental options * re organize conditionl logic, add leading condtional for exceptions * typo * seperate if statements * fix exception blocking * seperate execptions condtional into two small condtionals to prevent a always case * change conditional logic based on language * change delete+insert exception logic, and messages for both exceptions * change condition for more jinja language * remove default value assigned to tmp_relation_type, change delete+insert excpetion to only kick off if view is assigned and not unique_key not none * reword python exception * minor comment change, revert some condtional logic (need to deal with none) value * re add assignment of config * comment changes * put back low level part about append strategy * minor change to workign for excpetion * add changelog entry * fix previous changelog entry * change change log entry, remove some config from integration test * remove unnded comma (#405) Co-authored-by: Mila Page <67295367+VersusFacit@users.noreply.github.com> Co-authored-by: Mila Page <versusfacit@users.noreply.github.com> Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dbt-labs/dbt-core#6618
The copy-pasted tests had not been updated since fall 2021. They are functionally equivalent to the converted "adapter zone" test that we can now inherit.
Checklist
I have runchangie newto create a changelog entry