Modify adapter to support unified constraint fields #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleArk
approved these changes
Mar 15, 2023
McKnight-42
reviewed
Mar 15, 2023
dev-requirements.txt
Outdated
| @@ -1,7 +1,7 @@ | |||
| # install latest changes in dbt-core | |||
| # TODO: how to automate switching from develop to version branches? | |||
| git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core | |||
| git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter | |||
| git+https://github.com/dbt-labs/dbt-core.git@paw/ct-2198-unify-constraints#egg=dbt-core&subdirectory=core | |||
There was a problem hiding this comment.
flagging just to remind to repoint back to main here before merger
McKnight-42
approved these changes
Mar 15, 2023
mikealfare
reviewed
Mar 19, 2023
MichelleArk
reviewed
Mar 21, 2023
| @@ -10,8 +10,8 @@ | |||
|
|
|||
| _expected_sql_snowflake = """ | |||
| create or replace transient table {0} ( | |||
| id integer not null primary key , | |||
| color text , | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #491
Description
Modifies the adapter to support changes to the constraints fields in Core.
Checklist
changie newto create a changelog entry