Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match execute signature in dbt-core #598

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

aranke
Copy link
Member

@aranke aranke commented May 9, 2023

resolves #

fixes the signature change in execute from dbt-core here: dbt-labs/dbt-core#7545

Description

Checklist

@aranke aranke requested a review from a team as a code owner May 9, 2023 20:20
@aranke aranke requested a review from McKnight-42 May 9, 2023 20:20
@cla-bot cla-bot bot added the cla:yes label May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@nssalian
Copy link
Contributor

nssalian commented May 9, 2023

Worth updating the description that this PR is to fix the adapter execute signature because of the changes made here so folks can follow the change.

@aranke aranke changed the title update execute signature match execute signature in dbt-core May 9, 2023
@aranke aranke requested a review from nssalian May 9, 2023 21:15
@aranke aranke merged commit 3be577d into main May 9, 2023
@aranke aranke deleted the change_execute_signature branch May 9, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants