adding contributing.md to snowflake repo #79
Conversation
|
Really love to see this @McKnight-42. Any reason we stalled out here? Anything I can do to help? 😄 |
|
@VersusFacit i'm doing the bigquery one first to get a template for all the other adapters so moved made one for each at the base portion I had for bigquery and will update them based on all changes made to that one as they should generally be the same just updating tests examples and names. |
|
Great. Glad we have this context logged. Good to know this is still very much in the works 🖖 |
|
I agree and on that point i will add this here bigquery contributing.md |
…knight/contributing
…knight/contributing
There was a problem hiding this comment.
Left a bunch of comments now that I feel prepared enough to offer meaningful comments here! A lot of these where I gave a reasoned comment are of the p0 variety, where I think they should be addressed in some fashion, whether by the suggestions I wrote or with something inspired by them but better in your estimate!
Smaller comments are nitpicks for clarity, so take them or ignore them as your judgement sees fit. Do feel empowered to push back on any them. I'll keep an eye on this PR so we can get it merged.
There was a problem hiding this comment.
This one got bogged down in revisions and open asks. Matt did great work here (thanks Matt!).
To make sure this doesn't drag any longer, I put in a little time to get it pushed over the finish line. We can iterate on it as we see fit from here on. Also, I have let the community know about this
Description
Adding Contributing.md file to each seperated adapter
Checklist
CHANGELOG.mdand added information about my change to the "dbt-snowflake next" section.