Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo housekeeping pre-v1 #227

Closed
6 of 9 tasks
jtcohen6 opened this issue Oct 12, 2021 · 1 comment
Closed
6 of 9 tasks

Repo housekeeping pre-v1 #227

jtcohen6 opened this issue Oct 12, 2021 · 1 comment
Assignees
Labels

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Oct 12, 2021

Bring this repo into line with other Labs-maintained plugins (dbt-redshift, dbt-snowflake, dbt-bigquery).

The lists below are starting points; they're not exhaustive. In all cases, we should follow the examples set in the other plugin repos.

README

  • Ensure documentation is up-to-date at docs.getdbt.com (here + here). Then, remove all "documentation" from this readme
  • Use latest language + links from other plugin repos

Packaging

  • setup.py should use compatibility pin (~=) on dbt-core
  • dev_requirements.txt should install latest changes from dbt-core repo via git+
  • Remove requirements.txt (I think it's redundant)
  • Update release GHA workflow

CI

  • Update test/custom/base.py to include full integration test scaffolding, rather than from dbt_adapter_tests import DBTIntegrationTestBase
  • Switch main CI from CircleCI to GitHub Actions
  • Switch integration CI from CircleCI to GitHub Actions

I began this work in #223, but I got stuck with the integration test switch-over.

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants