-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for on_schema_change #229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
force-pushed
the
feature/on-schema-change
branch
from
October 14, 2021 19:28
8a25095
to
792981b
Compare
jtcohen6
changed the title
WIP support for on_schema_change
Add support for on_schema_change
Oct 14, 2021
jtcohen6
force-pushed
the
feature/on-schema-change
branch
from
October 14, 2021 20:03
792981b
to
dc0ce42
Compare
This was referenced Oct 14, 2021
jtcohen6
force-pushed
the
feature/on-schema-change
branch
from
October 15, 2021 15:10
dc0ce42
to
b0c7eae
Compare
leahwicz
approved these changes
Oct 15, 2021
jtcohen6
added a commit
that referenced
this pull request
Oct 18, 2021
* Add support for on_schema_change * Add changelog note
jtcohen6
added a commit
that referenced
this pull request
Oct 18, 2021
* Fix --store-failures (#233) * Fix --store-failures * Add chnagelog entry * Maybe this? * Fix indentation * Class inheritance, silly * Add support for on_schema_change (#229) * Add support for on_schema_change * Add changelog note * add persist_doc call to incremental model with tests (#234) * add persist_doc call to incremental model with tests * update changelog * add whatis to test for incremental * Reorg changelog Co-authored-by: Binh Pham <ebinhpham@gmail.com>
Merged
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #198
resolves #226
Support for:
ignore
fail
append_new_columns
, dropping columns is not supported on Spark/Deltasync_all_columns
I'm planning to rebase this against
main
. After merging, we'll backport to0.21.latest
, since this should have been included to coincide with the introduction ofon_schema_change
for other adapters in v0.21Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.