Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --store-failures #233

Merged
merged 5 commits into from
Oct 15, 2021
Merged

Fix --store-failures #233

merged 5 commits into from
Oct 15, 2021

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Oct 15, 2021

resolves #232

Backport to 0.21.latest after. (Unfortunately, this will just be broken in v0.20.x)

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Oct 15, 2021
@jtcohen6
Copy link
Contributor Author

This is also blocked by #231, i.e. upgrading the dbt-spark + dbt-core versions in main. We fixed this (aliasing the count(*) column in the unique test) in v0.20.2:

Runtime Error in test unique_view_model_id (models/schema.yml)
  ('42000', '[42000] [Simba][Hardy] (80) Syntax or semantic analysis error thrown in server while executing query. Error message from server: org.apache.hive.service.cli.HiveSQLException: Error running query: org.apache.spark.sql.AnalysisException: Attribute name "count(1)" contains invalid character(s) among " ,;{}()\\n\\t=". Please use alias to rename it.\n\tat org.apache.spark.sql.hive.thriftser (80) (SQLExecDirectW)')

@jtcohen6 jtcohen6 force-pushed the fix/test-store-failures branch from 189f081 to de96a8a Compare October 15, 2021 13:39
Copy link
Contributor

@sungchun12 sungchun12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super impressive how fast you moved on this based on a candid slack thread. LGTM

@jtcohen6 jtcohen6 merged commit 9be7bbb into main Oct 15, 2021
@jtcohen6 jtcohen6 deleted the fix/test-store-failures branch October 15, 2021 15:03
jtcohen6 added a commit that referenced this pull request Oct 18, 2021
* Fix --store-failures

* Add chnagelog entry

* Maybe this?

* Fix indentation

* Class inheritance, silly
jtcohen6 added a commit that referenced this pull request Oct 18, 2021
* Fix --store-failures (#233)

* Fix --store-failures

* Add chnagelog entry

* Maybe this?

* Fix indentation

* Class inheritance, silly

* Add support for on_schema_change (#229)

* Add support for on_schema_change

* Add changelog note

* add persist_doc call to incremental model with tests (#234)

* add persist_doc call to incremental model with tests

* update changelog

* add whatis to test for incremental

* Reorg changelog

Co-authored-by: Binh Pham <ebinhpham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid value error with dbt test --store-failures
3 participants