You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Amid all the merging for 0.15.3 (0.15.3 upgrade #65), the eventual implementation of get_catalog called list_relations + _massage_column_for_catalog. It never called _parse_relation. The unit tests on _parse_relation have been passing, but the output of that work never made it to the actual catalog.
The contract of get_catalog changed in dbt v0.16.0. We fixed in dbt-spark v0.16.1 by reimplementing some private methods (fix catalog generation #77).
Next steps
This isn't a regression per se, since this feature never really worked in v0.15.3... but we sure meant for it to ship then!
We should update the catalog private method reimplementations to include owner and table stats. The basis for this work should be the latest implementation on core adapters.
The text was updated successfully, but these errors were encountered:
The code for this does still mostly exist, it's just moved into parse_describe_extended. I think the reason owner isn't showing up is because of a combination of the more general catalog issues and the fact that I lost the stuff that handles relation-wide owners (via fetch table properties).
Statistics is failing for more complicated reasons, mostly the intersection of some irritating agate behavior ('' -> None) and some bad dbt-core behavior (None not being allowed).
I've got both of these working again locally with dbt-labs/dbt-core#2489 and some minor tweaks to re-add the properties query - I'll open a PR for that in a moment, once I track down all the bugs I think it fixes.
Background
_parse_relation
and passing it toget_catalog
get_catalog
calledlist_relations
+_massage_column_for_catalog
. It never called_parse_relation
. The unit tests on_parse_relation
have been passing, but the output of that work never made it to the actual catalog.get_catalog
changed in dbt v0.16.0. We fixed in dbt-spark v0.16.1 by reimplementing some private methods (fix catalog generation #77).Next steps
This isn't a regression per se, since this feature never really worked in v0.15.3... but we sure meant for it to ship then!
We should update the catalog private method reimplementations to include owner and table stats. The basis for this work should be the latest implementation on core adapters.
The text was updated successfully, but these errors were encountered: