-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add table owner + stats to catalog #90
Comments
The code for this does still mostly exist, it's just moved into Statistics is failing for more complicated reasons, mostly the intersection of some irritating agate behavior ( I've got both of these working again locally with dbt-labs/dbt-core#2489 and some minor tweaks to re-add the properties query - I'll open a PR for that in a moment, once I track down all the bugs I think it fixes. |
Background
_parse_relation
and passing it toget_catalog
get_catalog
calledlist_relations
+_massage_column_for_catalog
. It never called_parse_relation
. The unit tests on_parse_relation
have been passing, but the output of that work never made it to the actual catalog.get_catalog
changed in dbt v0.16.0. We fixed in dbt-spark v0.16.1 by reimplementing some private methods (fix catalog generation #77).Next steps
This isn't a regression per se, since this feature never really worked in v0.15.3... but we sure meant for it to ship then!
We should update the catalog private method reimplementations to include owner and table stats. The basis for this work should be the latest implementation on core adapters.
The text was updated successfully, but these errors were encountered: