0.15.3 upgrade #65
Merged
0.15.3 upgrade #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache schemas and relations
jtcohen6
reviewed
Mar 23, 2020
There was a problem hiding this comment.
This looks great.
I just did some end-to-end testing on local Spark and Databricks (including new merge incremental strategy). The only small thing I found is that both the seed and table materializations raise a new-in-0.15 deprecation warning:
* Deprecation Warning: The materialization ("table") did not explicitly return a list
of relations to add to the cache. By default the target relation will be
added, but this behavior will be removed in a future version of dbt.
For more information, see:
https://docs.getdbt.com/v0.15/docs/creating-new-materializations#section-6-returning-relations
That's something we should resolve before shipping. Otherwise, I think this is good to go.
beckjake
force-pushed
the
pr/0.15.3_upgrade
branch
from
bfa9f60
to
a24e4e3
Compare
beckjake
force-pushed
the
pr/0.15.3_upgrade
branch
from
a24e4e3
to
9b13d12
Compare
|
I must have lost those in the merge, I think I've fixed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was one heck of a merge!
This PR is obviously based on @SamKosky's totally awesome work with #46. Where possible, I've prioritized PRs that have merged since it was written over the contents of #46 that did the same thing
There's probably a significant amount of cruft left over (duplicated/vestigial methods and macros, especially). If you notice any in your review, please shout.
I basically can't rebase this, I'm sorry about that. Getting a merge to behave was hard enough!
There might be test failures, I didn't get spark-http running locally.