Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow kerberos #107

Merged
merged 2 commits into from
Sep 25, 2020
Merged

allow kerberos #107

merged 2 commits into from
Sep 25, 2020

Conversation

danielhstahl
Copy link
Contributor

Fixes #106

Allows users to specify auth and kerberos_service_name. This won't impact existing users who upgrade.

@beckjake
Copy link
Contributor

Thanks for your contribution @phillyfan1138! Can you add a unit test for this to test_adapter, similar to test_http_connection and test_thrift_connection?

I don't see how we can easily integration test this, but it would be nice to make sure we keep passing these credentials along in the future, at least.

@danielhstahl
Copy link
Contributor Author

Sure thing! Added.

@jtcohen6
Copy link
Contributor

Thanks for this @phillyfan1138!

@jtcohen6 jtcohen6 merged commit 5f19129 into dbt-labs:master Sep 25, 2020
@jtcohen6 jtcohen6 mentioned this pull request Nov 30, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support kerberos
3 participants