Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PyHive requirement to extra #127

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Move PyHive requirement to extra #127

merged 2 commits into from
Nov 30, 2020

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Nov 25, 2020

resolves #109

Description

  • sasl is an older package, not regularly maintained, and it's been bricking installs on a number of different systems
  • It's a requirement of PyHive[hive], which is used for thrift and http connection methods.
  • If a user wants to use the odbc connection method, that doesn't require PyHive at all. Today, inability to install sasl prevents them from being able to use the plugin.
  • This PR moves PyHive to be an extra requirement, rather than primary one
    • Pro: easier for ODBC users
    • Con: breaking change for existing users, who will need to replace pip install dbt-spark with pip install dbt-spark[PyHive]
    • Neutral: moves thrift to be an extra as well, since it's only needed by the same connection types

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@jtcohen6 jtcohen6 requested a review from kwigley November 25, 2020 00:41
@cla-bot cla-bot bot added the cla:yes label Nov 25, 2020
Copy link

@kwigley kwigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! pip install dbt-spark[PyHive] works for me! I tried to think of better keywords for these extras_require but nothing better came to mind.

@jtcohen6 jtcohen6 marked this pull request as ready for review November 30, 2020 19:04
@jtcohen6
Copy link
Contributor Author

Thanks @kwigley! I can't think of a great name—thrift feels best, but then it's misleading that this is a requirement for the http method as well—so sticking with the underlying package name is at least precise.

@jtcohen6 jtcohen6 merged commit bde721e into master Nov 30, 2020
@jtcohen6 jtcohen6 deleted the fix/pyhive-extras branch November 30, 2020 22:04
@jtcohen6 jtcohen6 mentioned this pull request Nov 30, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolate sasl as a dependency
2 participants