Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test_dbt_base on odbc-sql-endpoint spec (for now) #134

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

jtcohen6
Copy link
Contributor

Offers temporarily relief from #133 (does not resolve)

Description

It seems that set statements no longer work on SQL Analytics endpoints, and we use them in the incremental materialization. We'll bring this up with our contacts at Databricks.

In the meantime, this PR totally disables test_base within the odbc-sql-endpoint spec. We could override/reimplement it within the spec, to remove just the step where swappable is materialized: incremental, but I don't think it's worth it. As I see it, the main purpose of having a dedicated odbc-sql-endpoint spec is:

  • testing, at the most basic level, the two novel components of this connection method (ODBC driver + SQL endpoint)
  • declaring which dbt-spark functionality is not yet at parity

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@jtcohen6 jtcohen6 requested a review from kwigley December 31, 2020 11:38
@cla-bot cla-bot bot added the cla:yes label Dec 31, 2020
@jtcohen6 jtcohen6 merged commit e58ed5b into master Jan 4, 2021
@jtcohen6 jtcohen6 deleted the disable-failing-test branch January 4, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants