Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture hard deleted records in snapshots #144

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

jtcohen6
Copy link
Contributor

Resolved #143

Alternative: We stop overriding the default merge macros. Databricks' implementation is strictly better because it lets us use update * + insert *, but the default ones should still work, and it would avoid situations like this one where we miss an upstream improvement.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jan 15, 2021
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Feb 4, 2021

I really went back and forth on this: Should we just use the default versions of get_merge_sql and snapshot_merge_sql, since they already work on Delta? We need to override the incremental and snapshot materializations for other reasons, though, so it's not like we could get away with the full default implementation. I've decided to keep the change minimal for now.

@jtcohen6 jtcohen6 marked this pull request as ready for review February 4, 2021 10:25
@jtcohen6 jtcohen6 requested a review from kwigley February 4, 2021 10:25
@jtcohen6 jtcohen6 merged commit afea257 into master Feb 15, 2021
@jtcohen6 jtcohen6 deleted the feature/snapshot-hard-deletes branch February 15, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalidate hard deletes in snapshots
2 participants