Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/parse struct fields #203

Closed
wants to merge 8 commits into from

Conversation

SCouto
Copy link
Contributor

@SCouto SCouto commented Aug 16, 2021

resolves #202

Description

The issue was when parsing the schema, the current regex deal with inner struct fields as root fields, hence causing an error later because the column was not found (check issue #202 for a more detailed description)

Current one:
image

Proposed one:

image

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests (Modifyed)
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section. (Not sure if I did this right, let me know if it's something else to improve)

Sorry, something went wrong.

@cla-bot
Copy link

cla-bot bot commented Aug 16, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sergio Couto.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Aug 16, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sergio Couto.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Aug 16, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sergio Couto.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Aug 16, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sergio Couto.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Aug 16, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sergio Couto.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@SCouto SCouto marked this pull request as draft August 16, 2021 07:20
@cla-bot
Copy link

cla-bot bot commented Aug 16, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sergio Couto.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Aug 16, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sergio Couto.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@SCouto SCouto closed this Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in incremental models when using struct columns
1 participant