-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed get_columns_in_relation for open source delta table #207
Merged
jtcohen6
merged 2 commits into
dbt-labs:master
from
harryharanb:harryharanb/issue-199-snapshot-opensource-delta
Aug 23, 2021
Merged
fixed get_columns_in_relation for open source delta table #207
jtcohen6
merged 2 commits into
dbt-labs:master
from
harryharanb:harryharanb/issue-199-snapshot-opensource-delta
Aug 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this one, @harryharanb!
jtcohen6
pushed a commit
that referenced
this pull request
Aug 23, 2021
* fixed get_columns_in_relation for open source delta table * fixed E501 linting error and added change log
jtcohen6
added a commit
that referenced
this pull request
Aug 23, 2021
* fixed get_columns_in_relation for open source delta table (#207) * fixed get_columns_in_relation for open source delta table * fixed E501 linting error and added change log * fix issue parsing structs (#204) * fix issue parsing structs * include contributor in changelog * better error explanation Co-authored-by: Jeremy Cohen <jeremy@fishtownanalytics.com> Co-authored-by: Hariharan Banukumar <hariharan.banukumar@gmail.com> Co-authored-by: Sergio <ingscc00@gmail.com>
leahwicz
added a commit
that referenced
this pull request
Sep 17, 2021
* Show more detailed feedback when pyodbc import fails (#192) * Use exception chaining to get more detailed feedback when pyodbc is not installed * Remove pyodbc referenced before assignment * Set back try except * Add flake ignore * Add error message to RunTimeException Error chaining does not show the message in `dbt debug`. Therefore we explicitly add the message to the dbt.exceptions.RunTimeException * Update change log Add to change log that we print the import error when pyodbc can not be imported * Fix parenthesis in change log * Update changelog [skip ci] * Update changelog [skip ci] * Update changelog [skip ci] * Add support for ODBC Server Side Parameters (#201) * Add support for ODBC Server Side Parameters * Update CHANGELOG * Feature/able to retry all connections (#194) * Code changes * README changes * Improve error message default * Changelog * Changelog corrections * Restore accidental deletion * Update dbt/adapters/spark/connections.py Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com> * Add myself to Contributors Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com> * fixed get_columns_in_relation for open source delta table (#207) * fixed get_columns_in_relation for open source delta table * fixed E501 linting error and added change log * fix issue parsing structs (#204) * fix issue parsing structs * include contributor in changelog * better error explanation Co-authored-by: Jeremy Cohen <jeremy@fishtownanalytics.com> * Add adapter unique_field (#211) * Add adapter unique_field * Fix flake8. Add changelog entry * [Snyk] Fix for 2 vulnerabilities (#214) * fix: requirements.txt to reduce vulnerabilities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-SQLPARSE-1584201 - https://snyk.io/vuln/SNYK-PYTHON-THRIFT-474615 * Removing Thrift conflict with versions over 12 Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com> * 0.21.0b1 Release * Bumping version to 0.21.0b1 * Bumping to 0.21.0b2 * Bumping version to 0.21.0b2 Co-authored-by: Cor <jczuurmond@protonmail.com> Co-authored-by: Jeremy Cohen <jeremy@fishtownanalytics.com> Co-authored-by: Jethro Nederhof <jethro@jethron.id.au> Co-authored-by: gregingenii <80900458+gregingenii@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com> Co-authored-by: Hariharan Banukumar <hariharan.banukumar@gmail.com> Co-authored-by: Sergio <ingscc00@gmail.com> Co-authored-by: Snyk bot <github+bot@snyk.io> Co-authored-by: Ian Knox <ian.knox@fishtownanalytics.com> Co-authored-by: Leah Antkiewicz <leah.antkiewicz@dbtlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #199
Description
Enhanced get_columns_in_relation method to handle a bug in open source deltalake which doesnt return schema details in
show table extended in databasename like '*'
query outputChecklist
CHANGELOG.md
and added information about my change to the "dbt next" section.