Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge exclude columns spark #390

Merged
merged 9 commits into from
Sep 26, 2022
Merged

merge exclude columns spark #390

merged 9 commits into from
Sep 26, 2022

Conversation

dave-connors-3
Copy link
Contributor

@dave-connors-3 dave-connors-3 commented Jul 11, 2022 •
edited
Loading

resolves #5260 (dbt core issue)

Description

This PR adds the merge_exclude_columns feature for spark/databrick models (see related dbt core PR)

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

@cla-bot cla-bot bot added the cla:yes label Jul 11, 2022
@dave-connors-3 dave-connors-3 marked this pull request as ready for review July 20, 2022 18:00
@dave-connors-3 dave-connors-3 mentioned this pull request Jul 20, 2022
Merged
6 tasks
@jtcohen6 jtcohen6 added the triage:ready-for-review Externally contributed PR has functional approval, ready for code review from Core engineering label Aug 4, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

gshank
gshank approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code here is straightforward and does not look risky. This does not implement adapter zone tests, however, so that should be done in a separate ticket/pr.

@gshank gshank merged commit 31104df into main Sep 26, 2022
@gshank gshank deleted the feature/merge_exclude_columns branch September 26, 2022 18:49
@ueshin ueshin mentioned this pull request Sep 26, 2022
Merged
ueshin added a commit to databricks/dbt-databricks that referenced this pull request Sep 28, 2022
@ueshin
Add a test for "merge exclude columns spark". (#192)
ff97dd4 
### Description

Adds a test for "merge exclude columns spark" at dbt-labs/dbt-spark#390.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshank gshank gshank approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

@McKnight-42 McKnight-42 Awaiting requested review from McKnight-42

Assignees
No one assigned
Labels
cla:yes triage:ready-for-review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dave-connors-3 @gshank @jtcohen6