Fix/ldap password

[VShkaberda]

resolves #310
Created instead of #311

Description

Add password to build_ssl_transport and hive.connect. Allows to use LDAP authentication. Password is optional, so that it remains None for other auth if not specified in profiles.yml.

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

[jtcohen6]

Copying from #311 (comment):

The changes look straightforward, although ldap authentication isn't something we have automated testing for today.

Have you been able to confirm that this works for you, with your own cluster, when running from this branch locally?

[VShkaberda]

@jtcohen6 Yes, I can confirm it. We have Apache Kyuubi with LDAP authentication and these are the changes we made to be able to connect via thrift. We don't use ssl though, so I can't confirm it actually works with it, but I don't see significant differences making it non-working with ssl.

[ChenyuLInx]

LGTM! @VShkaberda thanks for contributing it!

[VShkaberda]

Hello, do you plan to merge this changes until the next release? There is a feeling that this PR has been forgotten. I saw an old comment in the issue thread

We should ultimately document what this method does

I'm not sure if it could be a blocker.

[nousot-cloud-guy]

I'm also interested in getting this PR merged. Is there anything blocking it at the moment?

[leahwicz]

Retriggering CI

[leahwicz]

@VShkaberda sorry for the delay in merging here! Would you be able to generate a changelog entry (instructions here) and then I can merge this in for the 1.3 release

[VShkaberda]

I tried to use dockerized changie, but had no success generating CHANGELOG. I'll try again and update this thread thereafter. PS. body in actions has broken link to dbt-spark contributing guide

[leahwicz]

@VShkaberda if you can't get it to work, just let me know and I can copy your commits to a branch and generate the changelog so we can get this in

[VShkaberda]

@leahwicz I end up installing changie and still can't figure out how to make it work. Trying changie new (as it is said in CONTRIBUTING.md) just gives me Error: open .changie.yml: No such file or directory. So I executed changie init and .chages/ and .changie.yaml were created and CHANGELOG.md was cleared. I'm not sure if this is how it is supposed to be. If it is I think it's a good idea to make it more clear in the CONTRIBUTING.md.

[leahwicz]

@VShkaberda I think I see what happened. The fork you were working on did not have the latest changie updates to it so that's why it was not working correctly. I fixed things up here so 🤞 that CI will pass and we can merge this in

[McKnight-42]

@ChenyuLInx seems this one is still failing for a python_model issue was curious if you had any ideas? or if this is a nuisance problem?

[ChenyuLInx]

@McKnight-42 sorry for seeing this late, I think we can merge it, I think the tests might be running with this branch, but we fixed that python tests on the main branch already

[nousot-cloud-guy]

@ChenyuLInx did this make it into the 1.3 release a few days ago?

[leahwicz]

@nousot-cloud-guy sorry but this did not make it into the 1.3 release 😞

[nousot-cloud-guy]

@leahwicz I'm guessing it'll be in 1.3 then. Any idea when that might be?

[nousot-cloud-guy]

Sorry I meant 1.4.

[leahwicz]

@nousot-cloud-guy yes- it will be in the 1.4 release which will be at the end of January