Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/incremental predicates #436

Merged
merged 18 commits into from
Dec 15, 2022
Merged

Feature/incremental predicates #436

merged 18 commits into from
Dec 15, 2022

Conversation

dave-connors-3
Copy link
Contributor

resolves #435

Description

Check out core PR 5702

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@cla-bot cla-bot bot added the cla:yes label Aug 23, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

This was referenced Aug 23, 2022
Merged
Merged
colin-rogers-dbt
colin-rogers-dbt approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fleid Fleid added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Dec 6, 2022
nathaniel-may
nathaniel-may approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@nathaniel-may nathaniel-may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@nathaniel-may
Copy link
Contributor

reran unit test failure.

@nathaniel-may
Copy link
Contributor

same failures.

@McKnight-42 McKnight-42 merged commit 24e4a96 into main Dec 15, 2022
@McKnight-42 McKnight-42 deleted the feature/incremental-predicates branch December 15, 2022 16:51
ueshin added a commit to databricks/dbt-databricks that referenced this pull request Dec 15, 2022
@dave-connors-3 @ueshin
Feature/incremental predicates (#161)
8124c35 
### Description

Updates the incremental materialization to include user supplied `incremental_predicates` and passes that to the `dbt_spark_get_incremental_sql` macro. 

The changes to `dbt_spark_get_incremental_sql` are updated in [dbt-spark PR #436](dbt-labs/dbt-spark#436)

Co-authored-by: Takuya UESHIN <ueshin@databricks.com>
@jtcohen6 jtcohen6 mentioned this pull request Jan 2, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@nathaniel-may nathaniel-may nathaniel-may approved these changes

Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1070] incremental predicates
5 participants
@dave-connors-3 @nathaniel-may @colin-rogers-dbt @Fleid @McKnight-42