Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1114] remove Cache call from get_columns_in_relation #451

Merged
merged 6 commits into from
Sep 15, 2022
Merged

[CT-1114] remove Cache call from get_columns_in_relation #451

merged 6 commits into from
Sep 15, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Sep 8, 2022 •
edited
Loading

resolves #447

Description

change to get_columns_in_relation to fix cache inconsistencies to fix cache issues in incremental models causing failure on on_schema_change

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@McKnight-42 McKnight-42 self-assigned this Sep 8, 2022
@cla-bot cla-bot bot added the cla:yes label Sep 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

ChenyuLInx
ChenyuLInx approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just want to make sure we have separate issue tracking the cache inconsistent problem?

@McKnight-42
Copy link
Contributor Author

@ChenyuLInx doesn't look like we have one currently, seems this method was chose as a short term fix, will create one

@McKnight-42 McKnight-42 mentioned this pull request Sep 14, 2022
Closed
colin-rogers-dbt
colin-rogers-dbt approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@McKnight-42 McKnight-42 merged commit 60f47d5 into main Sep 15, 2022
@McKnight-42 McKnight-42 deleted the mcknight/CT-1114 branch September 15, 2022 14:37
@jtcohen6 jtcohen6 mentioned this pull request Sep 21, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

@VersusFacit VersusFacit Awaiting requested review from VersusFacit

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1114] Prevent cache inconsistencies during on_schema_change
3 participants
@McKnight-42 @ChenyuLInx @colin-rogers-dbt