Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust tox passenv to be multiline #541

Closed
wants to merge 2 commits into from
Closed

Adjust tox passenv to be multiline #541

wants to merge 2 commits into from

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Dec 8, 2022 •
edited
Loading

dbt-labs/dbt-core#6405 provides a fair amount of context

Description

In tox 4, space-separated variables specified for passenv are not passed into the container.

[testenv:inline]
passenv = FOO BAR
☝️ doesn't work on tox 4

[testenv:separate-lines]
passenv =
    FOO
    BAR

  • will need backport to at least 1.1.latest

  • I have read the contributing guide and understand what's expected of me

  • I have signed the CLA

  • I have run this code in development and it appears to resolve the stated issue

  • This PR includes tests, or tests are not required/relevant for this PR

  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

  • I have run changie new to create a changelog entry

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Dec 8, 2022
@McKnight-42 McKnight-42 self-assigned this Dec 8, 2022
@cla-bot cla-bot bot added the cla:yes label Dec 8, 2022
VersusFacit
VersusFacit previously approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the failures on this from the syntax change?

@VersusFacit VersusFacit self-requested a review December 8, 2022 19:58
@VersusFacit VersusFacit dismissed their stale review December 8, 2022 19:58

We have errors

@McKnight-42 McKnight-42 closed this Dec 9, 2022
@mikealfare mikealfare deleted the mcknight/tox-passenv branch March 1, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare Awaiting requested review from mikealfare

@leahwicz leahwicz Awaiting requested review from leahwicz

@VersusFacit VersusFacit Awaiting requested review from VersusFacit

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@McKnight-42 @VersusFacit