Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT] adding allowlist_externals for bash script to tox tests, changing passenv #544

Merged
merged 2 commits into from
Dec 9, 2022
Merged

[BACKPORT] adding allowlist_externals for bash script to tox tests, changing passenv #544

merged 2 commits into from
Dec 9, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Dec 9, 2022 •
edited
Loading

resolves #
updating 1.3.latest tox.ini file for post tox 4.0.0 release use

Description

changing how passenv now has to have each variable on seperate line and adding allowlist_externals to allow for use of bash

Checklist

@McKnight-42 McKnight-42 self-assigned this Dec 9, 2022
@cla-bot cla-bot bot added the cla:yes label Dec 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Dec 9, 2022
@McKnight-42 McKnight-42 changed the title [BACKPORT] adding allowlist_externals for bash script to tox tests, changing pas… [BACKPORT] adding allowlist_externals for bash script to tox tests, changing paenv Dec 9, 2022
@McKnight-42 McKnight-42 changed the title [BACKPORT] adding allowlist_externals for bash script to tox tests, changing paenv [BACKPORT] adding allowlist_externals for bash script to tox tests, changing passenv Dec 9, 2022
colin-rogers-dbt
colin-rogers-dbt approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending PR checks

colin-rogers-dbt
colin-rogers-dbt approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending PR checks

@colin-rogers-dbt colin-rogers-dbt merged commit d12c332 into 1.3.latest Dec 9, 2022
@colin-rogers-dbt colin-rogers-dbt deleted the mcknight/1.3-passenv branch December 9, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@nathaniel-may nathaniel-may nathaniel-may approved these changes

@leahwicz leahwicz Awaiting requested review from leahwicz

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@McKnight-42 @nathaniel-may @colin-rogers-dbt