-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update used gh actions ahead of set-output, node12 deprecation #745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can now update this action to point to version 1.1.0
You'll also want to update triage-labels.yml
to use a more updated way of labeling issues. That action has been abandoned and uses node12.
.github/workflows/triage-labels.yml
Outdated
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
name: 'awaiting_response' | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out this is pretty straightforward.
The github-script repo has an example for adding a label
Here are the docs for removeLabel and addLabels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found the swap-labels action and will switch to that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do it across 5 repos, that's why I centralized it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
resolves #740
Description
Update versions of used Github Actions ahead of:
node12 deprecation (Summer 2023)
set-output deprecation (fully disabled on 31st May 2023)
Checklist
changie new
to create a changelog entry