Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update used gh actions ahead of set-output, node12 deprecation #745

Merged
merged 5 commits into from
May 16, 2023

Conversation

davidbloss
Copy link
Contributor

resolves #740

Description

Update versions of used Github Actions ahead of:

node12 deprecation (Summer 2023)
set-output deprecation (fully disabled on 31st May 2023)

Checklist

@davidbloss davidbloss added the Skip Changelog Skips GHA to check for changelog file label Apr 26, 2023
@davidbloss davidbloss requested review from emmyoop, a team and McKnight-42 April 26, 2023 20:44
@cla-bot cla-bot bot added the cla:yes label Apr 26, 2023
@davidbloss davidbloss requested review from a team and removed request for a team April 27, 2023 13:05
@davidbloss davidbloss self-assigned this Apr 27, 2023
@McKnight-42 McKnight-42 removed their request for review April 27, 2023 20:26
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now update this action to point to version 1.1.0

You'll also want to update triage-labels.yml to use a more updated way of labeling issues. That action has been abandoned and uses node12.

owner: context.repo.owner,
repo: context.repo.repo,
name: 'awaiting_response'
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this is pretty straightforward.
The github-script repo has an example for adding a label

Here are the docs for removeLabel and addLabels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found the swap-labels action and will switch to that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do it across 5 repos, that's why I centralized it.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@davidbloss davidbloss merged commit cce8975 into main May 16, 2023
@davidbloss davidbloss deleted the ADAP-486/update-used-gh-actions-versions branch May 16, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-486] replace all instances of set-output and node16
5 participants