Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
Fixes #81 (sort of...)
Prevent users from setting
database
just about anywhere. It would have been nice to makedatabase
andschema
equivalent, like in real spark, but that requires some ugly hacks on the dbt-core end.In the longer term, it would be nice to expose more things about
config
to plugins. Adapter specific configs can add new fields, but they can't remove them, and they can't even really check on them to see if they make sense because the builtin fields are examined before the adapter ones are considered. I'm not sure how exactly we could support such behavior in the dataclasses/hologram paradigm, but we can think about it more. Instead, the spark adapter now checks when relations are built, and errors out then. I don't think it's ideal, but it happens before dbt starts really running (when it's examining the manifest for what schemas to create) so at least there's that.This also upgrades the plugin to
0.17.0rc10.17.0rc2 in anticipation of the dbt 0.17.0 release - 0.17.0 support should just be abumpversion
away.