Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias database to allow matching between rows and Manifest #85

Closed
wants to merge 3 commits into from

Commits on May 22, 2020

  1. Alias database to allow matching between rows and Manifest

    Currently the docs generation is broken because we need to supply
    the database name when fetching the relations:
    
    if dct['table_database'] is None:
        dct['table_database'] = dct['table_schema']
    
    However, when we get the manifest we don't get the database:
    
    {CatalogKey(database='', schema='fokko', name='logistical_configuration_data'):
    	['model.dbtlake.logistical_configuration_data']}
    
    Therefore the keys never line up, and we can't match the Catalogs:
    
    https://github.com/fishtown-analytics/dbt/blob/9d0eab630511723cd0bc328f6f11d3ffe6c8f879/core/dbt/task/generate.py#L108
    
    We get from the describe relations:
    
    CatalogKey(database='fokko', schema='fokko', name='logistical_configuration_data')
    
    Due to the logic above.
    Fokko committed May 22, 2020
    Configuration menu
    Copy the full SHA
    cabc03b View commit details
    Browse the repository at this point in the history

Commits on May 23, 2020

  1. Configuration menu
    Copy the full SHA
    263308c View commit details
    Browse the repository at this point in the history
  2. Remove redudant code

    Fokko committed May 23, 2020
    Configuration menu
    Copy the full SHA
    4563394 View commit details
    Browse the repository at this point in the history