Fix: snapshots should create relations with database=none #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
snapshot
materialization twice needs to get or make a relation. Previously, it set thedatabase
by grabbing the value of the existing/model relation'sdatabase
. This resulting in an error:Solution
We should explicitly set
database=none
, in line with the changes in dbt-spark==0.17.0 that precludedatabase
from having a value.Note on testing
I caught this in my local end-to-end testing of all current features. This wasn't caught in automated integration testing because:
dbt-integration-tests
suite does not include adbt snapshot
stepThe resolution involves: