Remove some deprecated macros

[clrcrl]

This is a:

• bug fix PR with no breaking changes (please change the base branch to main)
• new functionality
• a breaking change

To do before merge

• Update base branch to dev/0.6.0 once Feature: use adapter.dispatch #267 is merged
• Update the changelog

Description & motivation

I removed union_tables and get_tables_by_prefix, which we deprecated >6 months ago as part of v0.2.4 in Dec 2019

I also removed get_tables_by_pattern — this was introduced in v0.5.0 and is functionally equivalent to get_tables_by_pattern_sql. Given few people would be using this macro (as it's a helper macro), we are going to go straight to removing it rather than deprecating it first.

We could also consider deprecating:

• The old arguments for surrogate_key macro: deprecated in v0.3.0 / April 2020
• identifier: deprecation warning added in v0.4.0 / April 2020 (deprecated before then but not marked as such)

Personally, I think we should wait until the next version of utils to deprecate those

Checklist

• I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
  • BigQuery
  • Postgres
  • Redshift
  • Snowflake
• I have updated the README.md (if applicable)
• I have added tests & descriptions to my models (and macros if applicable)
• I have added an entry to the changelog

[jtcohen6]

+0 −33

Nice! I agree, let's hold off on surrogate_key + identifier

[clrcrl]

@jtcohen6 — can you just sense check this for me (related to line #1). I looked at it a number of times and can't figure out why it's like this.

I guess similarly, why do we have column_override=none instead of column_override={}

[jtcohen6]

I think this is because of the python convention to set default arguments to none, always, out of fear of mutable default arguments.

It's less of an issue with strings and dicts than with arrays, so I think it's probably fine to make this change.