Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slugify macro to utils, use in pivot macro #314

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Add slugify macro to utils, use in pivot macro #314

merged 1 commit into from
Apr 16, 2021

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Dec 23, 2020 •
edited
Loading

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch
  • quality of life that is also a slightly breaking change

Description & motivation

Add a slugify macro that gets used in the pivot macro. The slugify macro turns strings into valid column names, and feels like a good idea

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • [ x Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@clrcrl clrcrl marked this pull request as draft December 23, 2020 18:07
@clrcrl
Copy link
Contributor Author

clrcrl commented Dec 23, 2020 •
edited
Loading

Yes, this is the failure I expected to see

@clrcrl clrcrl force-pushed the dev/0.7.0 branch 5 times, most recently from bbba960 to 60a3b3c Compare January 11, 2021 15:52
@clrcrl clrcrl marked this pull request as ready for review April 5, 2021 18:41
@clrcrl clrcrl requested a review from jtcohen6 April 5, 2021 18:43
@clrcrl clrcrl merged commit 8fb77b1 into dev/0.7.0 Apr 16, 2021
clrcrl pushed a commit that referenced this pull request May 19, 2021
@clrcrl
Add slugify macro to utils, use in pivot macro (#314)
445dbfd
clrcrl pushed a commit that referenced this pull request May 19, 2021
@clrcrl
Add slugify macro to utils, use in pivot macro (#314)
4843069
jtcohen6 added a commit that referenced this pull request Jun 6, 2021
@clrcrl @jtcohen6 @ChristopheDuong
0.7.0 into main (#372)
a729044 
* Tidy up changelog

* Add 0.7.0 entry to changelog

* Add order_by argument to get_column_values (#349)

* Add slugify macro to utils, use in pivot macro (#314)

* 0.20.0 compatibility (#371)

* Explicitly redefine Redshift -> default

* Upgrade generic tests

* Rm namespaces macro. New dispatch syntax

* Run tests with 0.20.0rc1

* Update changelog, readme

Co-authored-by: Jeremy Cohen <jeremy@fishtownanalytics.com>

* Simplify concat (#373)

* Postgres also have an alternative concat binary operation (#296)

* Update default implementation of concat macro

Co-authored-by: Christophe Duong <christophe.duong@gmail.com>

Co-authored-by: Jeremy Cohen <jeremy@fishtownanalytics.com>
Co-authored-by: Christophe Duong <christophe.duong@gmail.com>
@joellabes joellabes deleted the slugify-for-pivot branch October 21, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clrcrl