Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update multi-project docs for v1.5.0-b4 (March 16) #2945

Closed
1 task done
Tracked by #6747
jtcohen6 opened this issue Mar 2, 2023 · 1 comment · Fixed by #3100
Closed
1 task done
Tracked by #6747

Update multi-project docs for v1.5.0-b4 (March 16) #2945

jtcohen6 opened this issue Mar 2, 2023 · 1 comment · Fixed by #3100
Assignees
@jtcohen6
Labels
content Improvements or additions to content dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.5 Doc...

Comments

@jtcohen6
Copy link
Collaborator

jtcohen6 commented Mar 2, 2023 •
edited
Loading

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/docs/collaborate/publish/model-contracts
https://docs.getdbt.com/reference/resource-configs/contract
https://docs.getdbt.com/reference/resource-properties/columns

What part(s) of the page would you like to see updated?

  • data_type incorporated into preflight check
    • changed error message
    • data_type - name is recognized by data platform in SQL. If you can cast to it, it's a valid value for data_type. dbt does not do any type aliasing, it defers it to the data platform, and the data platform may have internal rules around aliasing, if there is a mismatch - you will see internal representation in error.
    • data_type is no longer just for metadata purposes, but is enforced when contract: true
  • model contracts supported for view materialization, in addition to table

Additional information

Relevant dbt-core issues:

https://www.notion.so/dbtlabs/dbt-Core-v1-5-docs-a2ae11be77bf47629f85faf7a3f27991
@jtcohen6 jtcohen6 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear idea Proposes an idea for new content dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) labels Mar 2, 2023
@jtcohen6 jtcohen6 self-assigned this Mar 2, 2023
@MichelleArk MichelleArk mentioned this issue Mar 3, 2023
Closed
@jtcohen6
Copy link
Collaborator Author

Also document: known limitations for constraints that are out of scope for v1.5, but could come later on.

  • no ref support for foreign_key / references constraints
  • no standard support (yet) for platform-specific rely instructions, unless implemented for that platform specifically
  • no support for schema evolution in incremental models - adding/removing constraints as the column spec changes, during incremental runs
  • (... any others? ...)

@jtcohen6 jtcohen6 mentioned this issue Mar 29, 2023
Merged
matthewshaver added a commit that referenced this issue Mar 30, 2023
@matthewshaver
Updates to Model Contracts (v1.5 betas) (#3100)
652662c 
resolves #2945
resolves #3023

## What are you changing in this pull request and why?

Updates to docs on Model Contracts based on changes in:
- v1.5.0-b4 (released on March 16)
- v1.5.0-b5 (released planned for Thursday, March 30)

Plus, some updates to the v1.5 upgrade guide. We should give this a full
once-over before the RC on April 13, including links out to other
related documentation changes.

cc @MichelleArk @matthewshaver I'm going to take another pass (later) in
the morning :)
@runleonarun runleonarun removed the idea Proposes an idea for new content label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtcohen6 jtcohen6

Labels
content Improvements or additions to content dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.5 Documentation
Development

Successfully merging a pull request may close this issue.

Updates to Model Contracts (v1.5 betas) dbt-labs/docs.getdbt.com
3 participants
@runleonarun @jtcohen6 @matthewshaver