Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping the original filename and table name when versioning for first time #3203

Closed
1 task done
dbeatty10 opened this issue Apr 17, 2023 · 0 comments · Fixed by #3232
Closed
1 task done

Keeping the original filename and table name when versioning for first time #3203

dbeatty10 opened this issue Apr 17, 2023 · 0 comments · Fixed by #3232
Assignees
Labels
content Improvements or additions to content dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@dbeatty10
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/docs/collaborate/govern/model-versions

What part(s) of the page would you like to see updated?

These changes need to be reviewed for completeness and correctness.

The instigating issue was this this didn't work for me:

  - v: 1
    config:
      alias: dim_customers # keep old relation location

This is what worked for me to keep both the filename and the table name the same as when it was un-versioned:
models/_models.yml

models:
  - name: dim_customers
    versions:
      - v: 1
        defined_in: dim_customers  # keep original file name

models/dim_customers.sql

{{ config(alias="dim_customers") }}

...

After my changes in #3195, this is not accurate 😢 :

defined_in: dim_customers # keep original relation name

It should be something like this instead:

defined_in: dim_customers # keep original file name

Additional information

No response

@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) labels Apr 17, 2023
@dbeatty10 dbeatty10 added this to the dbt Core v1.5 Documentation milestone Apr 17, 2023
@jtcohen6 jtcohen6 linked a pull request Apr 24, 2023 that will close this issue
@jtcohen6 jtcohen6 self-assigned this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants