Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax examples for model versions #3195

Merged
merged 3 commits into from
Apr 16, 2023
Merged

Fix syntax examples for model versions #3195

merged 3 commits into from
Apr 16, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Apr 16, 2023 •
edited
Loading

resolves #3194

Page preview

What are you changing in this pull request and why?

Update code examples for defined_in and exclude to align with the implementation (and code examples) in dbt-labs/dbt-core#7287:

  • e27c2da Example using defined_in property
  • 9da3e00 Fix the example to exclude column(s)
  • d0f5396 Use postgres-specific data types (since it is a neutral database platform and its data types can be easily ported)

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@netlify
Copy link

netlify bot commented Apr 16, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit d0f5396
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/643c21df03ba290008291644
😎 Deploy Preview https://deploy-preview-3195--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Apr 16, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Apr 16, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review April 16, 2023 16:51
@dbeatty10 dbeatty10 requested a review from a team as a code owner April 16, 2023 16:51
@dbeatty10
Copy link
Contributor Author

Hot-fixing without an independent review. Follow-up PRs can address any feedback.

@dbeatty10 dbeatty10 merged commit 950b443 into current Apr 16, 2023
@dbeatty10 dbeatty10 deleted the dbeatty/fix-model-version-example branch April 16, 2023 16:55
@dbeatty10 dbeatty10 mentioned this pull request Apr 17, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix syntax examples for model versions
1 participant
@dbeatty10