Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing node selection methods #3549

Closed
1 task done
dbeatty10 opened this issue Jun 15, 2023 · 0 comments · Fixed by #3548
Closed
1 task done

Missing node selection methods #3549

dbeatty10 opened this issue Jun 15, 2023 · 0 comments · Fixed by #3548
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: x-small This change will take under 3 hours to fix.

Comments

@dbeatty10
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/node-selection/methods

What part(s) of the page would you like to see updated?

These are the methods that are currently supported.

Out of these, nearly all of them are documented. Here are the ones that are missing:

  • The resource_type method (and example)
  • The wildcard method (and example)
  • Example that includes the file: method

Additional information

No response
@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Jun 15, 2023
@dbeatty10 dbeatty10 mentioned this issue Jun 15, 2023
Merged
1 task
@runleonarun runleonarun added priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: x-small This change will take under 3 hours to fix. labels Jun 16, 2023
dbeatty10 added a commit that referenced this issue Jun 23, 2023
@dave-connors-3 @mirnawong1 @dbeatty10
Update methods.md (#3548)
fdeca48 
resolves #3549

## What are you changing in this pull request and why?

This PR adds the (undocumented!) `resource_type` method that has been
possible for a long, long time.

Reason: we discovered a selection method wasn't documented! So we did 😎 

## Not done

#3549 mentions that there are no examples for the wildcard method that
include `wildcard:`. This seems okay since the intent in
dbt-labs/dbt-core#6599 was to use Unix-style
wildcards in conjunction with all the other selection methods.

So we're choosing not to add `wildcard:` examples in this PR. If needed,
they can always be added later.

## 🎩 


[Preview](https://deploy-preview-3548--docs-getdbt-com.netlify.app/reference/node-selection/methods#the-resource_type-method)

<img width="550" alt="image"
src="https://github.com/dbt-labs/docs.getdbt.com/assets/44704949/c46f18c5-d4ea-4e9a-815d-7f682efa4ee2">


## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.

---------

Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
@jtcohen6 jtcohen6 mentioned this issue Sep 27, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update methods.md dbt-labs/docs.getdbt.com
2 participants
@runleonarun @dbeatty10