-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul of Adapter Development Contributing Docs #1727
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
website/docs/docs/contributing/adapter-development/1-what-are-adapters.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
annotating images incorrectly, hopefully this works
website/docs/docs/contributing/adapter-development/1-what-are-adapters.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/5-promoting-a-new-adapter.md
Outdated
Show resolved
Hide resolved
…dbt.com into cordoning-adapter-docs
…rdoning-adapter-docs
website/docs/docs/contributing/adapter-development/1-what-are-adapters.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/4-documenting-a-new-adapter.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/4-documenting-a-new-adapter.md
Outdated
Show resolved
Hide resolved
Adding edits based on upcoming style guide
A few grammatical changes
website/docs/docs/contributing/adapter-development/5-promoting-a-new-adapter.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're a hero for putting this together. This will be such a huge improvement!
I gave an initial read-through and left a first round of feedback. To your specific questions:
- should this new Contributing/Adapter_Development subsection live in Guides?
IMO it would make sense there, but since the Docs team is also planning a reorg of the site's IA, I don't think we need to pick its perfect home right now.
Does it make sense that clicking on the sidebar section heading "Adapter Development" brings up the first doc in the series: What are adapters?? Or, should it have an overview page with the "What are adapters?" page explicitly listed in the sidebar? Perhaps both?
I definitely like it when conceptual sections have a landing page that introduces the section, especially for a topic like this where there's such a clear reading sequence.
Should maintaining your new adapter be a standalone page? What about Pre-Requisite Data Warehouse Features?
The "Building a new adapter" page is long, so I definitely wouldn't complain if it were split up into more & shorter pages. For the two sections you called out, it feels like the split is: "Before you build [DWH prereqs]", "Building your adapter [initial scaffolding etc]", "After you've built [maintaining]"
What information about adapter verification should go in this docs guide?
I trust your judgment here. The audience for this page is people developing adapters. I think you hit the most important pieces here, which are:
- why get your adapter verified
- how to talk to us about next steps (CTA)
I imagine there's more work in a follow-up PR to actually update the "Available Adapters" / "Supported Data Platforms" page with information about which adapters are validated and what that means. The audience there will be any user of dbt, including very new ones, who want to know if they should start building a dbt project to run on X platform.
website/docs/docs/contributing/adapter-development/1-what-are-adapters.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/1-what-are-adapters.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/1-what-are-adapters.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/1-what-are-adapters.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/1-what-are-adapters.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/6-verifying-a-new-adapter.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/6-verifying-a-new-adapter.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/6-verifying-a-new-adapter.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/6-verifying-a-new-adapter.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/6-verifying-a-new-adapter.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/6-verifying-a-new-adapter.md
Outdated
Show resolved
Hide resolved
website/docs/docs/contributing/adapter-development/6-verifying-a-new-adapter.md
Outdated
Show resolved
Hide resolved
…-a-new-adapter.md
…dbt.com into cordoning-adapter-docs
@matthewshaver @jtcohen6 thanks for your help here! I think we're almost there
See #1945 and a forthcoming PR where we combine the dbtlabs-, vendor-, and community-supported tables into one section with three new columns: "verified?" "latest verified version" and "maintained by" |
website/docs/docs/contributing/adapter-development/6-promoting-a-new-adapter.md
Outdated
Show resolved
Hide resolved
…-a-new-adapter.md
…dbt.com into cordoning-adapter-docs
Description & motivation
Questions
Contributing/Adapter_Development
subsection live inGuides
? @gwenwindflowerPreview
Direct link to preview adapter docs subsection:
https://deploy-preview-1727--docs-getdbt-com.netlify.app/docs/contributing/adapter-development/1-what-are-adapters
Checklist
If you added new pages (delete if not applicable):
website/sidebars.js
If you removed existing pages (delete if not applicable):
website/sidebars.js
_redirects