-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Metrics for 1.3 Changes #1954
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
added space after lineage
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
…t.com into changing_metric_spec
@mirnawong1 I've made updates to have querying information present in the metrics page, as well as some other formatting. Should be good for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @callum-mcdata this looks really great and added some comments and small tweaks for typos etc. other than those changes, looks good to me!
hey @callum-mcdata one thing i noticed, we have an h2 ## Declaring a metric - should this change to ## Defining a metric instead for consistency? |
…t.com into changing_metric_spec
Description & motivation
There are changes to the metric spec coming down the line in v1.3. PR here: dbt-labs/dbt-core#5775
This updates the metric page for the new spec.
To-do before merge
Have docs team review the language
Prerelease docs
If this change is related to functionality in a prerelease version of dbt (delete if not applicable):