Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Metrics for 1.3 Changes #1954

Merged
merged 18 commits into from
Sep 29, 2022
Merged

Updating Metrics for 1.3 Changes #1954

merged 18 commits into from
Sep 29, 2022

Conversation

callum-mcdata
Copy link
Contributor

@callum-mcdata callum-mcdata commented Sep 8, 2022

Description & motivation

There are changes to the metric spec coming down the line in v1.3. PR here: dbt-labs/dbt-core#5775

This updates the metric page for the new spec.

To-do before merge

Have docs team review the language

Prerelease docs

If this change is related to functionality in a prerelease version of dbt (delete if not applicable):

@github-actions github-actions bot added the content Improvements or additions to content label Sep 8, 2022
@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 0de0757
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6335b9ce168ed20008e9f5b0
😎 Deploy Preview https://deploy-preview-1954--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the size: medium This change will take up to a week to address label Sep 8, 2022
added space after lineage
@jtcohen6 jtcohen6 mentioned this pull request Sep 12, 2022
1 task
@jtcohen6 jtcohen6 linked an issue Sep 12, 2022 that may be closed by this pull request
1 task
callum-mcdata and others added 5 commits September 23, 2022 10:35
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
@dbt-labs dbt-labs deleted a comment from mirnawong1 Sep 23, 2022
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Sep 23, 2022
@callum-mcdata
Copy link
Contributor Author

@mirnawong1 I've made updates to have querying information present in the metrics page, as well as some other formatting. Should be good for review!

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @callum-mcdata this looks really great and added some comments and small tweaks for typos etc. other than those changes, looks good to me!

@mirnawong1
Copy link
Contributor

hey @callum-mcdata one thing i noticed, we have an h2 ## Declaring a metric - should this change to ## Defining a metric instead for consistency?

@jtcohen6 jtcohen6 linked an issue Sep 29, 2022 that may be closed by this pull request
1 task
@mirnawong1 mirnawong1 merged commit 785b6b9 into current Sep 29, 2022
@mirnawong1 mirnawong1 deleted the changing_metric_spec branch September 29, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to metric properties Update metrics.md to remove 'experimental' and 'new' language
2 participants