Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cross db macros #2050

Merged
merged 9 commits into from
Sep 26, 2022
Merged

New cross db macros #2050

merged 9 commits into from
Sep 26, 2022

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Sep 22, 2022

closes #2049

Description & motivation

  • Document new cross-database macros.
  • Add dbt. namespace prefix to all code examples

Prerelease docs

If this change is related to functionality in a prerelease version of dbt:

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit d48fb50
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/63320c1708b1de000aacde85
😎 Deploy Preview https://deploy-preview-2050--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Sep 22, 2022
@dbeatty10
Copy link
Contributor Author

dbeatty10 commented Sep 23, 2022

Update: This is SOLVED 🙏

@matthewshaver could you or someone else on the docs team help me troubleshoot something?

Do version blocks work with the Netflify deploy preview?

Here's why I ask...

Goal

My goal is to version the content of website/docs/reference/dbt-jinja-functions/cross-database-macros.md:

  • The majority of the page should first be available in version 1.2
  • This PR is intended to add a few new blocks of code first available in version 1.3
  • (If possible) no content of this page should be available before 1.2

Problem

The problem I'm experiencing:

  • This entire page is already versioned per these instructions
  • I tried to add version blocks per these instructions
  • But when I look at the deploy preview here, no content changes dynamically when I change the version number

@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Sep 24, 2022
@matthewshaver matthewshaver self-requested a review September 26, 2022 20:06
@dbeatty10 dbeatty10 marked this pull request as ready for review September 26, 2022 20:32
@dbeatty10 dbeatty10 merged commit a0160c4 into current Sep 26, 2022
@dbeatty10 dbeatty10 deleted the dbeatty/new-cross-db-macros branch September 26, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update list of cross-database macros
2 participants