Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to env var names #3134

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Updates to env var names #3134

merged 4 commits into from
Apr 6, 2023

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Apr 4, 2023

What are you changing in this pull request and why?

Updates docs to inform users of env var name changes for 1.5

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner April 4, 2023 15:28
@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 4930dcd
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/642ee6d58e2052000837152b
😎 Deploy Preview https://deploy-preview-3134--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Apr 4, 2023
@matthewshaver matthewshaver linked an issue Apr 4, 2023 that may be closed by this pull request
1 task
mirnawong1
mirnawong1 previously approved these changes Apr 5, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a non blocking suggestion re: active voice so approving this for you @matthewshaver !

Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
@matthewshaver matthewshaver merged commit fc1e7c2 into current Apr 6, 2023
@matthewshaver matthewshaver deleted the renamed-flags branch April 6, 2023 15:40
mirnawong1 added a commit that referenced this pull request Jan 23, 2024
[Preview](https://docs-getdbt-com-git-dbeatty-print-no-print-dbt-labs.vercel.app/reference/global-configs/print-output#suppress-print-messages-in-stdout)

resolves #4776

## What are you changing in this pull request and why?

I checked from v1.7 back to v1.1, and I couldn't get either of these to
work in any version:

Up to 1.5:
```yaml
config:
  no_print: true
```

1.5 and after:
```yaml
config:
  print: false
```

However, the `DBT_NO_PRINT` / `DBT_PRINT` environment variables and
`--no-print` and `--print` CLI flags _do_ work.

So I think the code example for `profiles.yml` was just accidentally
introduced in the following PRs, and we should remove it because it's
not actually an option for any versions.
- #1319
- #3134

For additional context, see:
- [Upgrading to
v1.1](https://docs.getdbt.com/docs/dbt-versions/core-upgrade/upgrading-to-v1.1#advanced-and-experimental-functionality)
- [Upgrading to
v1.5](https://docs.getdbt.com/docs/dbt-versions/core-upgrade/upgrading-to-v1.5#behavior-changes)
- #1102
- dbt-labs/dbt-core#4701
- #3122
- #3332

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [x] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renamed flags / env vars
2 participants