-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wording #3244
Update wording #3244
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@runleonarun This change in wording is good by me!
She also asked if we have a list / matrix available of which platforms support
constraints
and whether they are supported and/or enforced ? Or a link to a page with that info?
Yes, great idea! I made a table of these a few months ago, to guide the implementation for the DWH adapters that we maintain: dbt-labs/dbt-core#7067 (comment).
- How do you think we should make that extensible, for all the other DWHs?
- Do you want to do that as part of the scope of this PR, or should we open a new issue?
If we had adapter-specific feature support matrix pages similar to this, we could add a table for dbt model contract constraints. Along the lines of dbt-labs/dbt-core#7067 (comment), here's some brainstorming on representing how different constraints will behave per adapter:
|
Such good questions. I like Doug's suggestions, so we could maybe riff on them in the issue I opened to follow-up with this. #3282 |
Merging because this wording was approved by Jeremy earlier! |
What are you changing in this pull request and why?
Hey @jtcohen6 or @dbeatty10! @kbrock91 requested we change this a tiny bit. Can you let me know if this wording is OK? I also took the passive voice out to make the English a little simpler.
She also asked if we have a list / matrix available of which platforms support
constraints
and whether they are supported and/or enforced ? Or a link to a page with that info?Checklist