Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding semantic models to list #4156

Merged
merged 9 commits into from
Oct 12, 2023
Merged

Adding semantic models to list #4156

merged 9 commits into from
Oct 12, 2023

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Sep 28, 2023

Previews:

What are you changing in this pull request and why?

Adding semantic model support to list for dbt v1.6+

Resolves: #4134

Checklist

  • Add versioning components, as described in Versioning Docs

  • Add a note to the prerelease version Migration Guide

  • Review the Content style guide and About versioning so my content adheres to these guidelines.

  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner September 28, 2023 19:50
@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 8:03pm

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Sep 28, 2023
website/docs/reference/node-selection/methods.md Outdated Show resolved Hide resolved
website/docs/reference/commands/list.md Outdated Show resolved Hide resolved
matthewshaver and others added 3 commits October 12, 2023 14:22
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
@@ -10,7 +10,7 @@ The `dbt ls` command lists resources in your dbt project. It accepts selector ar
### Usage
```
dbt ls
[--resource-type {model,source,seed,snapshot,metric,test,exposure,analysis,default,all}]
[--resource-type {model,semantic_model,source,seed,snapshot,metric,test,exposure,analysis,default,all}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have a versioning component for the metric and semantic_model types, but maybe that is okay? 🤷

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking comment within website/docs/reference/commands/list.md about versioning components. Not sure if we want to leave that portion as unversioned or not 🤷

Everything else looks good!

@matthewshaver matthewshaver merged commit dc121c4 into current Oct 12, 2023
7 checks passed
@matthewshaver matthewshaver deleted the backport-semantic branch October 12, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt list supports semantic models
4 participants