Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model-contracts.md for supported models #4336

Merged
merged 12 commits into from
Jan 8, 2024

Conversation

nathangriffiths-cdx
Copy link
Contributor

@nathangriffiths-cdx nathangriffiths-cdx commented Oct 26, 2023

What are you changing in this pull request and why?

Update to show that incremental models with on_schema_change: fail are actually supported (only on_schema_change: append_new_columns is mentioned but this was changed here dbt-labs/dbt-core#8006)

Reformatted the list to make it clearer what is and isn't supported.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Update to show that incremental models with on_schema_change: fail are actually supported.

Reformat to make what is and isn't supported clearer.
@nathangriffiths-cdx nathangriffiths-cdx requested a review from a team as a code owner October 26, 2023 02:29
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 11:25am

@welcome
Copy link

welcome bot commented Oct 26, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@github-actions github-actions bot added the content Improvements or additions to content label Oct 26, 2023
@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 26, 2023
@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Oct 26, 2023
@matthewshaver
Copy link
Contributor

Thank you @nathangriffiths-cdx Made some minor alterations based on style guide but this is a nice improvement and we appreciate it.

@matthewshaver matthewshaver merged commit 515840b into dbt-labs:current Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content January-2024 new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants