Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing options #4740

Merged
merged 24 commits into from
Jan 19, 2024
Merged

add missing options #4740

merged 24 commits into from
Jan 19, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Jan 12, 2024

Resolves #3264

This pr sets to add missing user config options in the profiles.yml page:

some outstanding questions were raised

@mirnawong1 mirnawong1 requested a review from a team as a code owner January 12, 2024 12:46
Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 7:43pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Jan 12, 2024
mirnawong1 and others added 2 commits January 18, 2024 12:50
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbt-labs/dbt-core#9040 added indirect_selection.

Could we either add it within this PR or open a new PR for it?

Either way works for me, so whatever you prefer.

@dbeatty10
Copy link
Contributor

dbt-labs/dbt-core#9040 added indirect_selection.

Could we either add it within this PR or open a new PR for it?

Either way works for me, so whatever you prefer.

I opened #4773, and I'm going to approve this PR shortly (which should cause it to auto-merge) 🚀

@mirnawong1 mirnawong1 merged commit 318b1cd into current Jan 19, 2024
4 checks passed
@mirnawong1 mirnawong1 deleted the mwong-add-user-configs branch January 19, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs January-2024 size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing user config options within profiles.yml page
3 participants