-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast follows for Unit Testing #4975
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This feels very similar to / duplicative of this section that we already have on the reference page. Can we combine or separate into its own page and link to it instead? |
@graciegoheen What would be your preference? The fast follow note I have is to add data formats to this page but I can do it as a separate page. A few questions A sentence with a link is much easier to miss than an entire section of the document (maybe important because this is a new feature in beta). Is that going to hinder the beta for users? I can create it as a snippet as well, make it reusable without creating a new page for it. Let me know your thoughts. |
We already have this link: but we could specifically tag that to the existing format section. The reference doc section for unit testing only has a single section: Whereas the section for data tests has many: If we have a separate page for something as simple as limit for data testing, I don't see why we wouldn't follow a similar pattern for unit tests? I mainly just want to avoid maintaining duplicative versions of this documentation - since we already have this "format" section on the reference page: so a snippet could totally work as well! @runleonarun do you have thoughts here? |
@graciegoheen and @matthewshaver If we did that, we could make this tweak to the Before you Begin in the About Unit Testing page to look something like this:
This does make me wonder if we should do the same for versions and input? Otherwise it might be awkward. The input section could have more fleshed out examples like in other sections. |
I would be in favor of doing the same for versions, inputs, and overrides! Thanks @runleonarun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions. I know it's close to the release but I feel like we can clarify these things in unit testing to help beta users.
@@ -52,165 +52,8 @@ unit_tests: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewshaver we chatted about adding a heading to the file above. Something like
## File structure
@graciegoheen would this make sense for all files that lay out the configs or properties and their options like we do above?
website/docs/reference/resource-properties/unit-test-overrides.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
Adding info to the ref page
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! We can follow up with any other requests
What are you changing in this pull request and why?
Fast follows for unit tests:
Checklist