Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update advanced-ci.md #6339

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Update advanced-ci.md #6339

merged 4 commits into from
Oct 28, 2024

Conversation

hope-wat
Copy link
Contributor

I think the cached data is meant to explain how we create the preview in dbt Cloud. That's not clear from the language we have today.

If my understanding is inaccurate please do not pull this change in.

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • [] The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

@hope-wat
Update advanced-ci.md
e9a211e 
I think the cached data is meant to explain how we create the preview in dbt Cloud. That's not clear from the language we have today. 

If my understanding is inaccurate please do not pull this change in.
@hope-wat hope-wat requested a review from a team as a code owner October 22, 2024 21:22
@vercel Vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 28, 2024 0:51am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 22, 2024
joellabes
joellabes approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy for this to be merged as phrased, but have also added an alternative suggestion

website/docs/docs/deploy/advanced-ci.md Outdated Show resolved Hide resolved
@mirnawong1 mirnawong1 merged commit 743c699 into current Oct 28, 2024
10 of 11 checks passed
@mirnawong1 mirnawong1 deleted the advanced-ci-cached-data-hope-wat-patch-1 branch October 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 left review comments

@joellabes joellabes joellabes approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hope-wat @joellabes @mirnawong1