-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove v1.6 from docs #6375
Remove v1.6 from docs #6375
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw a few 1.6 references that might be worth removing:
- https://docs-getdbt-com-git-eol-dbt-labs.vercel.app/docs/collaborate/govern/model-versions#why-version-a-model Paragraph beginning with "dbt Core 1.6 introduced"
- https://docs-getdbt-com-git-eol-dbt-labs.vercel.app/best-practices/clone-incremental-models
- https://docs-getdbt-com-git-eol-dbt-labs.vercel.app/docs/collaborate/govern/project-dependencies#prerequisites (maybe just supported version of dbt" is good enough here)
Otherwise it looks good!
website/docs/docs/build/packages.md
Outdated
@@ -83,12 +83,8 @@ packages: | |||
version: [">=0.7.0", "<0.8.0"] | |||
``` | |||
|
|||
<VersionBlock firstVersion="1.7"> | |||
|
|||
Beginning in v1.7, `dbt deps` "pins" each package by default. See ["Pinning packages"](#pinning-packages) for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At what point would we get rid of "Beginning in v1.7?" Once 1.7 is no longer supported?
Thanks @runleonarun Anywhere it's indicating a prerequisite, I left it in. I did update some of the language to be consistent elsewhere. I left it in the Model Version doc because it tells a story about when we created it and why we used the feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for taking a look at those suggestions!
What are you changing in this pull request and why?
Removes v1.6 from the dropdown.
Removes content where v1.6 was "lastversion"
Cleans up "firstversion="1.7" blocks
Removes appropriate page version blocks
Checklist
🚀 Deployment available! Here are the direct links to the updated files: