Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1.6 from docs #6375

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Remove v1.6 from docs #6375

merged 5 commits into from
Oct 29, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Oct 28, 2024

What are you changing in this pull request and why?

Removes v1.6 from the dropdown.
Removes content where v1.6 was "lastversion"
Cleans up "firstversion="1.7" blocks
Removes appropriate page version blocks

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@matthewshaver matthewshaver requested review from dataders and a team as code owners October 28, 2024 20:11
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 29, 2024 9:07pm

@github-actions github-actions bot added content Improvements or additions to content size: large This change will more than a week to address and might require more than one person Docs team Authored by the Docs team @dbt Labs labels Oct 28, 2024
@matthewshaver matthewshaver changed the title [DO NOT MERGE UNTIL NOV 1] v1.6 removal from docs Remove v1.6 from docs Oct 28, 2024
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -83,12 +83,8 @@ packages:
version: [">=0.7.0", "<0.8.0"]
```

<VersionBlock firstVersion="1.7">

Beginning in v1.7, `dbt deps` "pins" each package by default. See ["Pinning packages"](#pinning-packages) for details.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At what point would we get rid of "Beginning in v1.7?" Once 1.7 is no longer supported?

@matthewshaver
Copy link
Contributor Author

I saw a few 1.6 references that might be worth removing:

Otherwise it looks good!

Thanks @runleonarun Anywhere it's indicating a prerequisite, I left it in. I did update some of the language to be consistent elsewhere.

I left it in the Model Version doc because it tells a story about when we created it and why we used the feature.

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for taking a look at those suggestions!

@runleonarun runleonarun merged commit f788c9d into current Oct 29, 2024
13 checks passed
@runleonarun runleonarun deleted the eol branch October 29, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants