Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manual-install-qs.md #6485

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Update manual-install-qs.md #6485

merged 4 commits into from
Nov 14, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Nov 14, 2024

current links not working, updating links to relative paths and steps


🚀 Deployment available! Here are the direct links to the updated files:

current links not working, updating links to relative paths and steps
@mirnawong1 mirnawong1 requested a review from a team as a code owner November 14, 2024 11:55
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 14, 2024 2:55pm

@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. content Improvements or additions to content guides Knowledge best suited for Guides Docs team Authored by the Docs team @dbt Labs and removed size: x-small This change will take under 3 hours to fix. labels Nov 14, 2024
@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Nov 14, 2024
@@ -36,7 +36,7 @@ The following steps use [GitHub](https://github.com/) as the Git provider for th
2. Select **Public** so the repository can be shared with others. You can always make it private later.
3. Leave the default values for all other settings.
4. Click **Create repository**.
5. Save the commands from "…or create a new repository on the command line" to use later in [Commit your changes](#commit-your-changes).
5. Save the commands from "…or create a new repository on the command line" to use later in [Commit your changes](https://docs.getdbt.com/guides/manual-install?step=6).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

I'm probably reading this very wrong but thought I'd ask just in case. Do you mean the user needs to save the commands from another location (ie is there a word / phrase missing) or will they be prompted to save the commands from this section > "or create a new repository on the command line"?

Kind Regards
Natalie

@@ -162,7 +162,7 @@ You should have an output that looks like this:

Commit your changes so that the repository contains the latest code.

1. Link the GitHub repository you created to your dbt project by running the following commands in Terminal. Make sure you use the correct git URL for your repository, which you should have saved from step 5 in [Create a repository](#create-a-repository).
1. Link the GitHub repository you created to your dbt project by running the following commands in Terminal. Make sure you use the correct git URL for your repository, which you should have saved from step 5 in [Create a repository](https://docs.getdbt.com/guides/manual-install?step=2).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mirnawong1

Should this sentence read "...running the following commands in your terminal" ? I wasn't sure if Terminal was a separate product or not.

Kind Regards
Natalie

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

I've approved this for you and left 2 questions. They're non blockers.

Kind Regards
Natalie

@mirnawong1 mirnawong1 merged commit 0f0c75e into current Nov 14, 2024
13 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-26 branch November 14, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants