Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify ado behavior #6705

Open
wants to merge 4 commits into
base: current
Choose a base branch
from
Open

clarify ado behavior #6705

wants to merge 4 commits into from

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Dec 20, 2024

this pr clarifies that for ado, private packages have to be configured using the org/repo path.

more details in internal slack: https://dbt-labs.slack.com/archives/C07C793M6EB/p1734715084356599?thread_ts=1734359013.848149&cid=C07C793M6EB


🚀 Deployment available! Here are the direct links to the updated files:

this pr clarifies that for ado, private packages have to be configured using the `org/repo` path. 

more details in internal slack: https://dbt-labs.slack.com/archives/C07C793M6EB/p1734715084356599?thread_ts=1734359013.848149&cid=C07C793M6EB
@mirnawong1 mirnawong1 requested a review from a team as a code owner December 20, 2024 18:14
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 20, 2024 7:07pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Dec 20, 2024
```

:::tip
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this shouldn't be a callout - can make this expandable or h4?

Copy link
Contributor

@ericbaumann ericbaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on updating these!

i'd recommend making sure that the bits about org/project/repo are indicated as an ADO concept

Comment on lines +201 to +205
For Azure DevOps repositories, you can only specify the `org/repo` path. The project tier is inherited from the source repository currently integrated with dbt Cloud.

- If the package repository is within the same project as your source repository, you’re in the clear. Simply specify org/repo in the private block.
- If the package repository is not within the same project as your source repository, this feature will not work for you until a future update.
- This currently only works within a single Azure DevOps project. If your repositories are in different projects within the same organization, you can't reference them in the `private` key at this time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add this as a "Prerequisite" of the feature? That, for ADO, the repo is located within the same org/project as your project's repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants