Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info about + prefix and splits config page #6932

Open
wants to merge 10 commits into
base: current
Choose a base branch
from

Conversation

@mirnawong1 mirnawong1 requested a review from a team as a code owner February 20, 2025 15:09
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Feb 21, 2025 8:15am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Feb 20, 2025
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: small This change will take 1 to 2 days to address labels Feb 20, 2025
@@ -1,5 +1,9 @@
---
title: Configs, properties, what are they?
sidebar_label: Configs and properties
intro_text: "Clarify the difference between properties and configs in dbt: properties describe resources, while configs control how dbt builds them in the warehouse"
description: "Clarify the difference between properties and configs in dbt: properties describe resources, while configs control how dbt builds them in the warehouse"
Copy link
Contributor

@matthewshaver matthewshaver Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're switching between "configs" in the title and descriptions and "configs" and "configurations" in the body. Should we include "Configurations" somewhere in the front matter or change them all to "configs"? Thinking about how search will be impacted

@@ -1,8 +1,9 @@
---
description: "Reference guide for configuring the dbt_project.yml file."
intro_text: "The dbt_project.yml file is a required file for all dbt projects. It contains important information that tells dbt how to operate your project."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's our best practice for intro text? Should it be describing the feature or describing what's on the page (for example "This is the reference page for configuring the dbt_project.yml, a required file for all dbt projects that contains important information that tells dbt how to operate your project."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little bit of both I'd say, intro text is probably a little longer than description

@@ -96,6 +97,27 @@ vars:

</File>

## The `+` prefix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already a separate ref page. Every use of + in the docs links to this page. Will this section cause confusion or hurt the search?

Copy link
Contributor Author

@mirnawong1 mirnawong1 Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, might be better to link to that page instead! Or i might turn it into a snippet so its available in multiple places

---
title: Define properties
sidebar_label: Define properties
intro_text: "Learn how to define properties for your resources in a properties.yml file"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above for best practices for intro text - Should our intro text be more descriptive than the descriptions?

@matthewshaver
Copy link
Contributor

For record keeping purposes, I suggest expanding the title and description of this PR since it touches a few more pages and sections than just the + prefix

@mirnawong1 mirnawong1 changed the title add info about + prefix add info about + prefix and splits config page Feb 21, 2025
mirnawong1 and others added 2 commits February 21, 2025 08:09
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The + for configs ONLY applies to dbt_project.yml and not elsewhere
2 participants