Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.9 support #34

Closed
beckjake opened this issue Aug 26, 2020 · 0 comments · Fixed by #37
Closed

Python 3.9 support #34

beckjake opened this issue Aug 26, 2020 · 0 comments · Fixed by #37

Comments

@beckjake
Copy link
Contributor

Python 3.9 changed the way typing.Optional is represented - in particular

This used to be how python represented a typing.Optional. An Optional is really just a Union that includes None in python 3.6-3.8:

>>> typing.Optional[int]
typing.Union[int, NoneType]

But in python 3.9, the typing.Optional is preserved when there is only None + one item:

>>> typing.Optional[int]
typing.Optional[int]

This breaks hologram (and therefore dbt) because it only checks for Union everywhere. It shouldn't be too hard to fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant