We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.9 changed the way typing.Optional is represented - in particular
typing.Optional
This used to be how python represented a typing.Optional. An Optional is really just a Union that includes None in python 3.6-3.8:
Union
None
>>> typing.Optional[int] typing.Union[int, NoneType]
But in python 3.9, the typing.Optional is preserved when there is only None + one item:
>>> typing.Optional[int] typing.Optional[int]
This breaks hologram (and therefore dbt) because it only checks for Union everywhere. It shouldn't be too hard to fix!
The text was updated successfully, but these errors were encountered:
(#34) Add support for Python 3.9
2eaa91b
f04a6b8
Merge pull request #37 from fishtown-analytics/fix/py39-compat
ae61097
Successfully merging a pull request may close this issue.
Python 3.9 changed the way
typing.Optional
is represented - in particularThis used to be how python represented a typing.Optional. An Optional is really just a
Union
that includesNone
in python 3.6-3.8:But in python 3.9, the typing.Optional is preserved when there is only None + one item:
This breaks hologram (and therefore dbt) because it only checks for Union everywhere. It shouldn't be too hard to fix!
The text was updated successfully, but these errors were encountered: