Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SL-1642] [Feature] Add Support for Consistent SQL Query Generation #1020

Closed
3 tasks done
plypaul opened this issue Jan 31, 2024 · 0 comments · Fixed by #1015
Closed
3 tasks done

[SL-1642] [Feature] Add Support for Consistent SQL Query Generation #1020

plypaul opened this issue Jan 31, 2024 · 0 comments · Fixed by #1015
Labels
enhancement New feature or request Metricflow Created by Linear-GitHub Sync triage Tasks that need to be triaged

Comments

@plypaul
Copy link
Contributor

plypaul commented Jan 31, 2024 •
edited
Loading

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Currently, SQL generated by MetricFlowEngine is not completely consistent between identical queries because there are SQL elements (e.g. sub-query aliases) that are generated via a counter that carries state from query to query. To make use of query caching as provided by some SQL engines, the proposed feature would make the ID generation consistent between otherwise identical MF queries.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

SL-1642
@plypaul plypaul added enhancement New feature or request triage Tasks that need to be triaged labels Jan 31, 2024
@plypaul plypaul changed the title [Feature] Add Support for Consistent SQL Query Generation [SL-1642] [Feature] Add Support for Consistent SQL Query Generation Jan 31, 2024
plypaul added a commit that referenced this issue Feb 1, 2024
@plypaul
Add change log for #1020.
cfe58ae
@plypaul plypaul added the Metricflow Created by Linear-GitHub Sync label Feb 5, 2024
@plypaul plypaul added this to the v.13 milestone Feb 5, 2024
@plypaul plypaul added the Metricflow Gap Created by Linear-GitHub Sync label Feb 5, 2024
plypaul added a commit that referenced this issue Feb 6, 2024
@plypaul
Add change log for #1020.
9d18c94
@plypaul plypaul closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
@plypaul plypaul reopened this Feb 8, 2024
@plypaul plypaul modified the milestones: v.13, Exports & Caching Foundation Feb 8, 2024
plypaul added a commit that referenced this issue Feb 8, 2024
@plypaul
Add change log for #1020.
e6720d7
@plypaul plypaul added Metricflow Created by Linear-GitHub Sync and removed Metricflow Created by Linear-GitHub Sync Metricflow Gap Created by Linear-GitHub Sync labels Feb 8, 2024
plypaul added a commit that referenced this issue Feb 9, 2024
@plypaul
Add change log for #1020.
073a1ee
@plypaul plypaul modified the milestones: Exports & Caching Foundation, Caching Feb 14, 2024
@plypaul plypaul mentioned this issue Feb 15, 2024
Merged
plypaul added a commit that referenced this issue Feb 15, 2024
@plypaul
Add change log for #1020.
6b8857a
plypaul added a commit that referenced this issue Feb 15, 2024
@plypaul
Add change log for #1020.
0a7dd7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Metricflow Created by Linear-GitHub Sync triage Tasks that need to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Support for Consistent SQL Query Generation dbt-labs/metricflow
1 participant
@plypaul