Time Spine Source Node #1543
Closed
Time Spine Source Node #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a huge commit but it's all just snapshot description changes. There are only three files with changed logic.
courtneyholcomb
force-pushed
the
court/simp5
branch
5 times, most recently
from
dcd97f6
to
a517f46
Compare
courtneyholcomb
commented
Nov 22, 2024
| , subq_18.bookers AS bookers | ||
| FROM ***************************.mf_time_spine subq_20 | ||
| DATE_TRUNC('month', time_spine_src_28006.ds) AS booking__ds__month | ||
| , DATE_TRUNC('week', time_spine_src_28006.ds) AS metric_time__week |
There was a problem hiding this comment.
why did this column order change?
courtneyholcomb
commented
Nov 22, 2024
| SELECT | ||
| martian_day AS metric_time__martian_day | ||
| FROM ***************************.mf_time_spine subq_14 | ||
| subq_16.martian_day AS metric_time__martian_day |
There was a problem hiding this comment.
noooope lol fixing this might have to do with multiple time spines?
courtneyholcomb
commented
Nov 22, 2024
| ) subq_17 | ||
| FROM ***************************.mf_time_spine time_spine_src_28006 | ||
| ) subq_20 | ||
| WHERE ( |
There was a problem hiding this comment.
filter now in outer query, makes sense with alias change, but why did this change?
courtneyholcomb
commented
Nov 22, 2024
| @@ -7,8 +7,8 @@ sql_engine: DuckDB | |||
| -- Constrain Time Range to [2020-01-01T00:00:02, 2020-01-01T00:00:08] | |||
| -- Pass Only Elements: ['metric_time__second',] | |||
| SELECT | |||
| DATE_TRUNC('second', ts) AS metric_time__second | |||
| ts AS metric_time__second | |||
There was a problem hiding this comment.
Put up a separate commit for this change
courtneyholcomb
force-pushed
the
court/simp5
branch
3 times, most recently
from
1628530
to
4cdae61
Compare
These tests aren't testing anything particularly useful, and they will require significant refactoring to work with changes up the stack. Remove them instead.
This will change later when we support multiple time spine nodes per query. For now, move the error to the core function so that we don't need to do error handling everywhere this gets used (which will be several places further up the stack). Also adds a helper to improve readability.
… for time spines The metric time nodes are used for resolving metric_time without metrics. The read SQL nodes will be used for time spine joins.
This will enable more efficient queries. We require this grain to be accurate.
courtneyholcomb
force-pushed
the
court/simp5
branch
from
6a517ec
to
f39948c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.